Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] Add support for AV1 itags #706

Merged
merged 1 commit into from
Jul 22, 2023
Merged

[YouTube] Add support for AV1 itags #706

merged 1 commit into from
Jul 22, 2023

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

I don't really like this approach, since this can include 60 fps streams as well as HDR streams... #488 is the ideal solution, but there's a lot of work to be done on the NewPipe app side which I know nothing about

Closes #672

@AudricV AudricV added enhancement youtube service, https://www.youtube.com/ labels Aug 7, 2021
@litetex litetex mentioned this pull request Aug 24, 2021
Open
3 tasks
@litetex
Copy link
Member

litetex commented Aug 24, 2021 •
edited
Loading

Tested this on a experimental branch with #488 in the NewPipe app.
https://www.youtube.com/watch?v=kJQP7kiw5Fk worked fine (maybe a non AV1-codec was used - idk).
However videos like https://www.youtube.com/watch?v=aqz-KE-bpKQ failed on higher resolutions (>1080p):
grafik

See also #488 (comment)

TL;DR
Would not recommend merging currently

@FireMasterK
Copy link
Member Author

Discussion continued on #488 (comment), this behavior happens on high-resolution WEBM and AV1 streams, and even HDR streams and is to be fixed on the App side, and not the extractor.

@opusforlife2 opusforlife2 mentioned this pull request Aug 29, 2021
Open
@ghost
Copy link

ghost commented Aug 29, 2021

Unfortunately that means until #488 is merged this won't be merged?

@FireMasterK
Copy link
Member Author

Neither of these PRs can be merged currently as there is work to be done in the app to adapt for these changes.

@ehyoitsdavid
Copy link

ehyoitsdavid commented Dec 21, 2022 •
edited
Loading

Android 14 will force the support of software AV1 decoding, even if the hardware does not support. Will you consider supporting it in NewPipe (hopefully) by the time Android 14 is released to general public?

@TobiGr TobiGr mentioned this pull request Feb 4, 2023
Merged
5 tasks
@TobiGr TobiGr self-assigned this Feb 4, 2023
@ag2s20150909

This comment was marked as spam.

Sign in to view
TobiGr
TobiGr approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that took me way too long.

@TobiGr TobiGr merged commit 8ebbe1b into TeamNewPipe:dev Jul 22, 2023
1 check failed
@FireMasterK FireMasterK deleted the av1-itags branch July 22, 2023 14:32
This was referenced Jul 31, 2023
Merged
Closed
@AudricV AudricV changed the title Add support for AV1 itags. [YouTube] Add support for AV1 itags Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heroku-miraheze heroku-miraheze heroku-miraheze approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees

@TobiGr TobiGr

Labels
enhancement youtube service, https://www.youtube.com/
Projects
Before rewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AV1 itags
7 participants
@FireMasterK @litetex @ehyoitsdavid @ag2s20150909 @TobiGr @heroku-miraheze @AudricV